-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Revert "Disable validation-test/Python/build_swift.swift" #29481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit df2e553. Repair the preset rather than disabling the tests.
@swift-ci please test tensorflow |
CC: @shabalind |
I dont think that the sourcekit failures should be related? |
@swift-ci please clean test tensorflow |
@swift-ci please clean test tensorflow |
It looks like upd. Ah, wait a moment, it looks like the test failures are legit now? E.g. in https://ci-external.swift.org/job/swift-PR-TensorFlow-Linux/3458/console:
upd2. Okay, I see. SourceKit tests seem to only be failing on macOS: https://ci-external.swift.org/job/swift-PR-TensorFlow-macOS/2598/console. |
@swift-ci please clean test tensorflow |
I think that this is an infrastructure issue now - please switch to python 2. |
I'm uninstalling Python 3 from the Linux CI machines. Let's see if tests pass with that change. Linux toolchains should be built with Python 3, since that's required for swift-jupyter. However, apple/swift CI runs on different Linux machines, so uninstalling Python 3 should be fine. |
@swift-ci Please clean test tensorflow linux |
@swift-ci Please test tensorflow linux |
@swift-ci Please clean test tensorflow linux |
@swift-ci Please test tensorflow linux gpu |
1 similar comment
@swift-ci Please test tensorflow linux gpu |
@dan-zheng I think that icu-devel was removed from the builder |
Yes. Unfortunately, I'm currently unable to ssh to the Linux GPU CI machine - it hangs. Let's try to debug the connection internally. |
Merging now to unblock progress, ignoring the Linux GPU CI failure. We're currently unable to connect to CI machines for some reason. Once the connection issue is fixed, we can fix Linux CPU CI robustly (by installing missing |
This reverts commit df2e553. Repair
the preset rather than disabling the tests.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.