Skip to content

Revert "Disable validation-test/Python/build_swift.swift" #29481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

compnerd
Copy link
Member

This reverts commit df2e553. Repair
the preset rather than disabling the tests.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

This reverts commit df2e553.  Repair
the preset rather than disabling the tests.
@compnerd compnerd requested review from burmako and dan-zheng January 27, 2020 22:42
@compnerd
Copy link
Member Author

@swift-ci please test tensorflow

@compnerd
Copy link
Member Author

CC: @shabalind

@compnerd
Copy link
Member Author

I dont think that the sourcekit failures should be related?

@compnerd
Copy link
Member Author

@swift-ci please clean test tensorflow

@burmako
Copy link

burmako commented Jan 28, 2020

@compnerd Let me see whether tensorflow builds correctly and passes tests. #29347 was green when we merged but maybe something got screwed up.

@burmako
Copy link

burmako commented Jan 28, 2020

@swift-ci please clean test tensorflow

@burmako
Copy link

burmako commented Jan 28, 2020

It looks like tensorflow passes utils/build-script --preset=tensorflow_test on my gLinux workstation. Maybe that was a spurious error that got fixed by a clean build?

upd. Ah, wait a moment, it looks like the test failures are legit now? E.g. in https://ci-external.swift.org/job/swift-PR-TensorFlow-Linux/3458/console:

FAIL: Swift(linux-x86_64) :: Python/build_swift.swift (529 of 12640)
******************** TEST 'Swift(linux-x86_64) :: Python/build_swift.swift' FAILED ********************
Script:
--
: 'RUN: at line 10';   /usr/bin/python /home/swiftci/jenkins/workspace/swift-PR-TensorFlow-Linux/swift/utils/build_swift/run_tests.py
--
Exit Code: 1

Command Output (stderr):
--
Traceback (most recent call last):
  File "/home/swiftci/jenkins/workspace/swift-PR-TensorFlow-Linux/swift/utils/build_swift/run_tests.py", line 19, in <module>
    import argparse
  File "/home/swiftci/jenkins/workspace/swift-PR-TensorFlow-Linux/swift/utils/build_swift/argparse/__init__.py", line 18, in <module>
    
ImportError: cannot import name ArgumentDefaultsHelpFormatter

--

********************

upd2. Okay, I see. SourceKit tests seem to only be failing on macOS: https://ci-external.swift.org/job/swift-PR-TensorFlow-macOS/2598/console.

@burmako
Copy link

burmako commented Jan 28, 2020

@compnerd I've disabled failing tests in #29503 to unblock everyone's work pending a proper investigation.

@burmako
Copy link

burmako commented Jan 28, 2020

@swift-ci please clean test tensorflow

@compnerd
Copy link
Member Author

I think that this is an infrastructure issue now - please switch to python 2.

@dan-zheng
Copy link
Contributor

dan-zheng commented Jan 30, 2020

I think that this is an infrastructure issue now - please switch to python 2.

I'm uninstalling Python 3 from the Linux CI machines. Let's see if tests pass with that change.

Linux toolchains should be built with Python 3, since that's required for swift-jupyter. However, apple/swift CI runs on different Linux machines, so uninstalling Python 3 should be fine.

@dan-zheng
Copy link
Contributor

@swift-ci Please clean test tensorflow linux

@dan-zheng
Copy link
Contributor

@swift-ci Please test tensorflow linux

@dan-zheng
Copy link
Contributor

@swift-ci Please clean test tensorflow linux

@dan-zheng
Copy link
Contributor

@swift-ci Please test tensorflow linux gpu

1 similar comment
@dan-zheng
Copy link
Contributor

@swift-ci Please test tensorflow linux gpu

@compnerd
Copy link
Member Author

@dan-zheng I think that icu-devel was removed from the builder

@dan-zheng
Copy link
Contributor

@dan-zheng I think that icu-devel was removed from the builder

Yes. Unfortunately, I'm currently unable to ssh to the Linux GPU CI machine - it hangs. Let's try to debug the connection internally.

@dan-zheng
Copy link
Contributor

Merging now to unblock progress, ignoring the Linux GPU CI failure.

We're currently unable to connect to CI machines for some reason. Once the connection issue is fixed, we can fix Linux CPU CI robustly (by installing missing apt-get dependencies).

@dan-zheng dan-zheng merged commit b5aa972 into swiftlang:tensorflow Jan 31, 2020
@compnerd compnerd deleted the tensorflow-tests branch January 31, 2020 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants