[TF] Fix tensorflow_osx_base build preset.
#29550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deleted `skip-install-swiftsyntax-module` flag from `tensorflow_osx_base` preset. I didn't spend time to track down when/why exactly the flag was deleted. `tensorflow_osx_base` is now more in-sync with `mixin_osx_package_base`.
|
@dan-zheng #29481 has that change as well - do we want to merge ignoring the failure? |
Sorry, I didn't notice that #29481 also has the fix! Fixing the test failures is important so CI continues to pass. It seems the test failures are related to re-enabling How about merging this patch (just the build preset fix) instead? Running CI isn't even necessary because CI uses the |
|
Closing in favor of pre-existing fix #29481, which also adds tests. That PR should be merged soon, since tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deleted
skip-install-swiftsyntax-moduleflag fromtensorflow_osx_basepreset.I didn't spend time to track down when/why exactly the flag was deleted.
tensorflow_osx_baseis now more in-sync withmixin_osx_package_base.Locally verified the fix on macOS.
We haven't run into this issue for a while since we haven't triggered fresh macOS builds using the
tensorflow_osx_basepreset.