Skip to content

[Python: flake8] Update the utils/python_lint.py script to fail with a non-zero exit code if flake8 and flake8-import-order are not installed. #29613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

[Python: flake8] Update the utils/python_lint.py script to fail with a non-zero exit code if flake8 and flake8-import-order are not installed. #29613

merged 1 commit into from
Feb 4, 2020

Conversation

Rostepher
Copy link
Contributor

No description provided.

@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@shahmishal
Copy link
Member

We should execute this test on macOS or Linux, we dont need to run it twice.

@shahmishal
Copy link
Member

Recommenced macOS

@Rostepher
Copy link
Contributor Author

Looks like the Linux tests failed because they don't have flake8 installed.

@shahmishal
Copy link
Member

Looks like the Linux tests failed because they don't have flake8 installed.

I would recommend setting the test to only run on macOS, because we dont currently have flake8 installed.

[Python: flake8] Update the utils/python_lint.py script to fail with …
c096e29 
…a non-zero exit code if flake8 and flake8-import-order are not installed.
@Rostepher Rostepher force-pushed the no-more-flaky-flake8 branch from a4650ff to c096e29 Compare February 3, 2020 21:10
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher
Copy link
Contributor Author

Rostepher commented Feb 3, 2020 •
edited
Loading

So for historical reasons the utils/gyb.py and utils/line-directive scripts were linting themselves in their doctests. Since we run a flake8 lint pass over both of those scripts in the validation-test/Python/python_lint.swift test it's no longer necessary to have those scripts lint themselves.

Per an offline discussion with @shahmishal I've also set the Python lint test to run only on macOS for the time being. In the future we can install flake8 on the Linux bots and run this test there.

@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test Linux platform

@Rostepher Rostepher merged commit 7ff9ba1 into swiftlang:master Feb 4, 2020
@Rostepher Rostepher deleted the no-more-flaky-flake8 branch February 4, 2020 00:20
@Rostepher Rostepher mentioned this pull request Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal shahmishal approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rostepher @shahmishal @compnerd