Skip to content

[Python: flake8] Update the utils/python_lint.py script to fail with a non-zero exit code if flake8 and flake8-import-order are not installed (5.2 branch). #29696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2020
Merged

[Python: flake8] Update the utils/python_lint.py script to fail with a non-zero exit code if flake8 and flake8-import-order are not installed (5.2 branch). #29696

merged 3 commits into from
Feb 7, 2020

Conversation

Rostepher
Copy link
Contributor

This PR cherry-picks the changes from #29309 and #29613 to the 5.2 branch, which should fix the now failing validation-test/Python/line-directive.swift and validation-test/Python/gyb.swift tests that started failing once flake8 was installed on more nodes.

I also needed to update the docs/conf.py script so the Python linter wouldn't fail.

Ross Bayer added 3 commits February 6, 2020 16:48
[Build System: Python] Cleaned-up the python_lint.py script.
533ddf3 
(cherry picked from commit b904179)
[Python: flake8] Update the utils/python_lint.py script to fail with …
866db27 
…a non-zero exit code if flake8 and flake8-import-order are not installed.

(cherry picked from commit c096e29)
[Python: flake8] Update the docs/conf.py script to appease the flake8…
f69557a 
… linter.
@Rostepher Rostepher requested a review from shahmishal February 7, 2020 00:57
@Rostepher Rostepher changed the base branch from master to swift-5.2-branch February 7, 2020 00:57
@Rostepher Rostepher changed the title No more flaky flake8 5.2 [Python: flake8] Update the utils/python_lint.py script to fail with a non-zero exit code if flake8 and flake8-import-order are not installed. Feb 7, 2020
@Rostepher Rostepher changed the title [Python: flake8] Update the utils/python_lint.py script to fail with a non-zero exit code if flake8 and flake8-import-order are not installed. [Python: flake8] Update the utils/python_lint.py script to fail with a non-zero exit code if flake8 and flake8-import-order are not installed (5.2 branch). Feb 7, 2020
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher
Copy link
Contributor Author

@swift-ci please python lint

@Rostepher Rostepher requested a review from najacque February 7, 2020 00:59
@swift-ci
Copy link
Contributor

swift-ci commented Feb 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - f69557a

@Rostepher
Copy link
Contributor Author

@swift-ci please test macOS platform

@shahmishal shahmishal merged commit 70ec5bd into swiftlang:swift-5.2-branch Feb 7, 2020
@swift-ci
Copy link
Contributor

swift-ci commented Feb 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - f69557a

@Rostepher Rostepher deleted the no-more-flaky-flake8-5.2 branch February 7, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

@najacque najacque Awaiting requested review from najacque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rostepher @swift-ci @shahmishal