[stdlib/private][os log] Minor changes to the new os log overlay #29630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
ravikandhadai
force-pushed
the
oslog-minor-changes
branch
from
c74168e to
6d0e8ec
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
os log overlay @_transparent so that they will be inlined in their callers even annotated as @_optimize(none). Make the OSLogPrototypeCompileTest.swift test suite check only the output of the OSLogOptimization pass instead of the output of the Onone pipeline. This will make the tes more resilient to adding mandatory optimizations later in the pass pipeline. Also, remove a duplicate test from the OSLogPrototypeExecTest suite.
ravikandhadai
force-pushed
the
oslog-minor-changes
branch
from
6d0e8ec to
e631c66
Compare
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate tiny helper functions in the new os log overlay @_transparent so that they will be inlined in their callers even annotated as @_optimize(none).
Make the OSLogPrototypeCompileTest.swift test suite check only the output of the OSLogOptimization pass instead of the output of the Onone pipeline. This will make the tests more resilient to adding mandatory optimizations later in the pass pipeline. Also, remove a duplicate test from the OSLogPrototypeExecTest suite.
Also, add support for interpolating UInts (this will be superseded by this PR once it lands #29518)