test: loosen the differentiability witness test #29711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently a difference between the tensorflow branch and the master branch. On tensorflow, the differentiability support is merged into the standard library. This changes the decoration of the witness. Loosen the test to accept either. We should change the tensorflow branch to generate the `_Differentiation` module with the support and then auto-import the module in the longer term. This can be gated by the `-enable-experimental-autodifferentiation` flag to the driver to gain the same behaviour on both the branches.
|
@swift-ci please smoke test |
rxwei
reviewed
Feb 7, 2020
| @@ -161,7 +161,7 @@ sil_differentiability_witness hidden [parameters 0 1] [results 0] <τ_0_0 where | |||
| // ROUNDTRIP: vjp: @AD__generic__vjp_src_0_wrt_0_1 : $@convention(thin) <τ_0_0 where τ_0_0 : Differentiable> (@in_guaranteed τ_0_0, Float) -> (@out τ_0_0, @owned @callee_guaranteed (@in_guaranteed τ_0_0.TangentVector) -> (@out τ_0_0.TangentVector, Float)) | |||
| // ROUNDTRIP: } | |||
|
|
|||
| // IRGEN-LABEL: @AD__generic_PSSRS16_Differentiation14DifferentiableRzl = hidden global { i8*, i8* } { | |||
| // IRGEN: @AD__generic_PSSRS{{16_Differentiation|s}}14DifferentiableRzl = hidden global { i8*, i8* } { | |||
There was a problem hiding this comment.
Is there a reason why -LABEL was removed?
There was a problem hiding this comment.
I was running into a matching issue (I expect the regular expression was throwing it off).
dan-zheng
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a difference between the tensorflow branch and the
master branch. On tensorflow, the differentiability support is merged
into the standard library. This changes the decoration of the witness.
Loosen the test to accept either.
We should change the tensorflow branch to generate the
_Differentiationmodule with the support and then auto-import themodule in the longer term. This can be gated by the
-enable-experimental-autodifferentiationflag to the driver to gainthe same behaviour on both the branches.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.