[AutoDiff] NFC: make FileCheck test work on master and tensorflow. #29839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuhan
approved these changes
Feb 14, 2020
|
@swift-ci Please smoke test |
This is necessary because the `Differentiable` protocol exists in stdlib core on `tensorflow` branch but in the `_Differentiation` module on `master` branch. The robust solution is to add auto-import `_Differentiation` logic to `tensorflow`.
dan-zheng
force-pushed
the
autodiff-cleanup
branch
from
dfaff65 to
6a4b99f
Compare
|
Pushed a minor fix. Verified that the test passes on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because the
Differentiableprotocol exists in stdlib coreon
tensorflowbranch but in the_Differentiationmodule onmasterbranch.The robust solution is to add auto-import
_Differentiationlogic totensorflow.Related patch: #29711.