-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Build system recognizes OpenBSD. #30082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This conflicts with a big shuffle that we are trying to do (#29807), Id appreciate it if you could wait for that |
Sure! There's no rush. I have orthogonal changes that can come in another PR, but let me know on #30083 if you'd rather I hold on those as well. |
This needs to be rebased to the current tree |
393fe77
to
c1e61f2
Compare
Done. |
c1e61f2
to
fb82224
Compare
fb82224
to
f49c49d
Compare
:-( I really dislike that its expanding the horrors of the SDK setup which I'm trying to remove. Sadly, no way around that currently. |
@swift-ci please test |
Build failed |
Commit for CMake and build scripts to recognize OpenBSD. To keep this commit relatively short, this just deals with the rather simple and uncontroversial changes to the build system. Note that OpenBSD calls "x86_64" as "amd64", Since the Swift stdlib will be put in a subdirectory named after ARCH, to ensure the standard library is properly found later, we use the native architecture name for OpenBSD in the build system rather than trying to deal with the difference the other way around.
f49c49d
to
f8d0174
Compare
Fixed the linter failure. Should pass cleanly now. |
@swift-ci python lint |
@swift-ci test |
Build failed |
Linux failure looks unrelated (same failures exhibited on older prior builds like 19724). |
It is unrelated - corelibs has a poor implementation of filesystem APIs on Linux which is causing a non-deterministic failure in SourceKit-LSP's tests. I'll merge this when we unblock this. |
Not sure if it’s fixed, but @swift-ci smoke test Linux platform |
@swift-ci smoke test Linux platform |
@swift-ci smoke test Linux |
1 similar comment
@swift-ci smoke test Linux |
Still hitting this... @swift-ci please clean smoke test Linux platform |
⛵ |
Commit for CMake and build scripts to recognize OpenBSD. To keep this
commit relatively short, this just deals with the rather simple and
uncontroversial changes to the build system.
Note that OpenBSD calls "x86_64" as "amd64", Since the Swift stdlib will
be put in a subdirectory named after ARCH, to ensure the standard
library is properly found later, we use the native architecture name for
OpenBSD in the build system rather than trying to deal with the
difference the other way around.