Skip to content

Build system recognizes OpenBSD. #30082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

3405691582
Copy link
Member

Commit for CMake and build scripts to recognize OpenBSD. To keep this
commit relatively short, this just deals with the rather simple and
uncontroversial changes to the build system.

Note that OpenBSD calls "x86_64" as "amd64", Since the Swift stdlib will
be put in a subdirectory named after ARCH, to ensure the standard
library is properly found later, we use the native architecture name for
OpenBSD in the build system rather than trying to deal with the
difference the other way around.

@compnerd
Copy link
Member

This conflicts with a big shuffle that we are trying to do (#29807), Id appreciate it if you could wait for that

@3405691582
Copy link
Member Author

3405691582 commented Feb 26, 2020

Sure! There's no rush.

I have orthogonal changes that can come in another PR, but let me know on #30083 if you'd rather I hold on those as well.

@compnerd
Copy link
Member

compnerd commented Mar 5, 2020

This needs to be rebased to the current tree

@3405691582 3405691582 force-pushed the OpenBSD_Port_Build branch from 393fe77 to c1e61f2 Compare March 6, 2020 03:14
@3405691582
Copy link
Member Author

Done.

@compnerd
Copy link
Member

compnerd commented Apr 3, 2020

:-( I really dislike that its expanding the horrors of the SDK setup which I'm trying to remove. Sadly, no way around that currently.

@compnerd
Copy link
Member

compnerd commented Apr 3, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2020

Build failed
Swift Test OS X Platform
Git Sha - f49c49d4f8d46fa8e1e12456c0faa16ed3238083

Commit for CMake and build scripts to recognize OpenBSD. To keep this
commit relatively short, this just deals with the rather simple and
uncontroversial changes to the build system.

Note that OpenBSD calls "x86_64" as "amd64", Since the Swift stdlib will
be put in a subdirectory named after ARCH, to ensure the standard
library is properly found later, we use the native architecture name for
OpenBSD in the build system rather than trying to deal with the
difference the other way around.
@3405691582 3405691582 force-pushed the OpenBSD_Port_Build branch from f49c49d to f8d0174 Compare April 3, 2020 17:34
@3405691582
Copy link
Member Author

Fixed the linter failure. Should pass cleanly now.

@CodaFi
Copy link
Contributor

CodaFi commented Apr 9, 2020

@swift-ci python lint

@CodaFi
Copy link
Contributor

CodaFi commented Apr 9, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f8d0174

@3405691582
Copy link
Member Author

Linux failure looks unrelated (same failures exhibited on older prior builds like 19724).

@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

It is unrelated - corelibs has a poor implementation of filesystem APIs on Linux which is causing a non-deterministic failure in SourceKit-LSP's tests. I'll merge this when we unblock this.

@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

Not sure if it’s fixed, but

@swift-ci smoke test Linux platform

@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

@swift-ci smoke test Linux platform

@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

@swift-ci smoke test Linux

1 similar comment
@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

@swift-ci smoke test Linux

@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

Still hitting this...

@swift-ci please clean smoke test Linux platform

@CodaFi
Copy link
Contributor

CodaFi commented Apr 12, 2020

@CodaFi CodaFi merged commit 22b0526 into swiftlang:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants