Swift Basic/Driver recognizes OpenBSD. #30083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Feb 27, 2020
| class LLVM_LIBRARY_VISIBILITY OpenBSD : public GenericUnix { | ||
| protected: | ||
| std::string getDefaultLinker() const override; | ||
|
|
compnerd
approved these changes
Feb 27, 2020
Add the platform conditional and set up other basics for the toolchain. The ConditionalCompilation tests are updated to match, since otherwise they seem to trip when building on non-OpenBSD platforms. The Driver/linker test is updated to ensure lld is passed on this platform. Note that OpenBSD calls "x86_64" as "amd64", so we use that name for the architecture instead of trying to alias one to the other, as this makes things simpler.
3405691582
force-pushed
the
OpenBSD_Port_BasicDriver
branch
from
714fe26 to
0d3b92d
Compare
Added to Driver/linker.swift, cribbing off existing stanzas, since it was simple enough. |
finagolfin
approved these changes
Feb 27, 2020
|
@swift-ci please test |
|
Cool! ⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the platform conditional and set up other basics for the toolchain.
The ConditionalCompilation tests are updated to match, since otherwise
they seem to trip when building on non-OpenBSD platforms.
This is orthogonal to pr #30082, which needs to wait for pending build system changes. This can proceed independently, but can wait if necessary.