[CSBindings] Open collection before binding parameter only if origina… #30113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l argument type failed Instead of always opening argument type represented by a collection without type variables (to support subtyping when element is a labeled tuple), let's try original type first and if that fails use a slower path with indirection which attempts `array upcast`. Doing it this way helps to propagate contextual information faster which fixes a performance regression. Resolves: rdar://problem/54580247
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Mar 16, 2020
…indings This is a follow-up to swiftlang#30113 which cased a regression because it was placed under a check which allows direct supertypes to be inferred if previous (failing) binding has a supertype as well which has nothing to do with collection inference. Let's combine supertype check and inference logic to avoid such confusion in the future. Resolves: rdar://problem/60501780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l argument type failed
Instead of always opening argument type represented by a collection
without type variables (to support subtyping when element is a labeled tuple),
let's try original type first and if that fails use a slower path with
indirection which attempts
array upcast. Doing it this way helps topropagate contextual information faster which fixes a performance regression.
Resolves: rdar://problem/54580247
Resolves: rdar://problem/57138194