[Incremental] Fix overly conservative fingerprint bug & fix tests. #30123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file's referenced-name-tracker contains a use of a declaration that is also defined in the same file, do not create a dependency arc from the declaration to the file-as-a-whole. The arc is not needed because the driver, detecting a change in a declaration in a file, will schedule recompilation anyway. The arc is too conservative because if the type's fingerprint changes, it will dirty the entire file and thus all other declarations in it as well.
Also fix a typo in a test that hid this failure.
Strengthen a unit test to also detect this failure.