Skip to content

Generate scripts for component-wise lit invocations #30673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Generate scripts for component-wise lit invocations #30673

wants to merge 6 commits into from

Conversation

scentini
Copy link
Contributor

With this change, the test directory will contain 3 scripts:

  • swift-check-silgen.sh (runs lit.py on test/SILGen as well as any directory containing a file that has 'silgen' string in its name.)
  • swift-check-irgen.sh (runs lit.py on test/IRGen as well as any directory containing a file that has 'irgen' string in its name.)
  • swift-check-typecheck.sh (runs lit.py on test/Sema as well as any directory containing a file that has 'typecheck' in its name.)

@scentini
Copy link
Contributor Author

cc @gribozavr

CodaFi
CodaFi reviewed Mar 27, 2020
View reviewed changes
compnerd
compnerd reviewed Mar 27, 2020
View reviewed changes
scentini added 2 commits April 6, 2020 13:10
@scentini
Generate scripts for component-wise lit invocations
ba1f9ad 
With this change, the test directory will contain 3 scripts:
 * swift-check-silgen.sh (runs lit.py on test/SILGen as well as any directory containing a file that has "silgen" string in its name.)
 * swift-check-irgen.sh (runs lit.py on test/IRGen as well as any directory containing a file that has "irgen" string in its name.)
 * swift-check-typecheck.sh (runs lit.py on test/SEMA as well as any directory containing a file that has "typecheck" in its name.)
@scentini
Use --filter option with lit. Adress comments
48efcc0
gribozavr
gribozavr reviewed Apr 6, 2020
View reviewed changes
@gribozavr
Copy link
Contributor

swift-check-silgen.sh (runs lit.py on test/SILGen as well as any directory containing a file that has 'silgen' string in its name.)

WDYT about slightly different semantics, "runs lit.py on test/SILGen as well as any test file that has 'silgen' in its name"?

@gribozavr
Copy link
Contributor

gribozavr commented Apr 6, 2020 •
edited
Loading

swift-check-silgen.sh (runs lit.py on test/SILGen as well as any directory containing a file that has 'silgen' string in its name.)

WDYT about slightly different semantics, "runs lit.py on test/SILGen as well as any test file that has 'silgen' in its name"?

@scentini fixed it in the latest commit that uses lit --filter=....

@gribozavr
Copy link
Contributor

@swift-ci Please smoke test

compnerd
compnerd reviewed Apr 7, 2020
View reviewed changes
@gribozavr
Copy link
Contributor

gribozavr commented Apr 7, 2020 •
edited
Loading

An alternative approach: enhancing utils/run-test: #30850

@gribozavr gribozavr mentioned this pull request Apr 8, 2020
Merged
@compnerd
Copy link
Member

This is no longer needed right?

@scentini
Copy link
Contributor Author

I believe that #30850 was deemed sufficient. Closing the PR

@scentini scentini closed this Apr 16, 2020
@gribozavr gribozavr added the c++ interop Feature: Interoperability with C++ label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

@gribozavr gribozavr gribozavr left review comments

@CodaFi CodaFi CodaFi left review comments

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scentini @gribozavr @compnerd @CodaFi