Skip to content

utils/run-test: added lit's --filter option #30850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

gribozavr
Copy link
Contributor

Added a pass through of lit's --filter option to utils/run-test, to allow running a subset of tests, for example ./utils/run-test --filter=irgen runs tests in test/IRGen and any other test with "irgen" in its name.

Added a pass through of lit's `--filter` option to utils/run-test, to
allow running a subset of tests, for example `./utils/run-test
--filter=irgen` runs tests in `test/IRGen` and any other test with
"irgen" in its name.
@gribozavr
Copy link
Contributor Author

The context for this patch is our proposal to reorganize C and C++ interop tests. In the resolution, @CodaFi said that him and Doug want us to build tooling that allow to run just the IRGen, SILGen, and Sema tests as was possible previously.

I suggested @scentini to implement new scripts that would allow engineers to do that -- which she did in PR 30673, however, adding more scripts to invoke tests seems to have risen some objections. I'm sorry for suggesting this approach and wasting your time.

We looked into other options and found the utils/run-test script, which could be enhanced to run only certain types of tests. This enhancement is implemented in this PR.

@CodaFi I hope this addresses your concerns. I was trying to contact you over the past few days but couldn't get a response. I hope this enhancement creates sufficient tooling for running subsets of tests.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to expose --filter through run-test.

@compnerd
Copy link
Member

compnerd commented Apr 8, 2020

@swift-ci please test

@CodaFi
Copy link
Contributor

CodaFi commented Apr 8, 2020

I like this approach a lot. Let's do it.

⛵️

@CodaFi CodaFi merged commit e162d0a into swiftlang:master Apr 8, 2020
@gribozavr gribozavr deleted the run-test-filter branch April 8, 2020 21:28
@gribozavr gribozavr added the c++ interop Feature: Interoperability with C++ label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants