Skip to content

build: explicitly execute line-directive-tool with Python3 #30992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

compnerd
Copy link
Member

The line-directive-tool is Python3 compliant. Use the Python3
interpreter to execute this tool.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The `line-directive-tool` is Python3 compliant.  Use the Python3
interpreter to execute this tool.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

CC: @drexin

Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, \cc @shahmishal

@shahmishal shahmishal requested review from shahmishal and edymtt April 13, 2020 18:00
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - cba8723

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@compnerd compnerd merged commit 41958f9 into swiftlang:master Apr 14, 2020
@compnerd compnerd deleted the the-impossible-future branch April 14, 2020 00:11
edymtt added a commit to edymtt/swift that referenced this pull request Apr 23, 2020
Move detection of Python code into dedicate CMake module, so it can be
reused for workflows that do not rely on reading the main
`CMakeLists.txt`.

Builds upon swiftlang#30992, swiftlang#31020

Addresses rdar://62245784
edymtt added a commit to edymtt/swift that referenced this pull request Apr 23, 2020
Move detection of Python code into dedicate CMake module, so it can be
reused for workflows that do not rely on reading the main
`CMakeLists.txt`.

Builds upon swiftlang#30992, swiftlang#31020

Addresses rdar://62245784

(cherry picked from commit 7bc15b8)
edymtt added a commit that referenced this pull request Apr 23, 2020
)

This is to support workflows that do not rely on reading the main
CMakeLists.txt.

Based upon #30992, #31020

Addresses rdar://62245784
edymtt added a commit that referenced this pull request Apr 23, 2020
…#31235)

This is to support workflows that do not rely on reading the main
CMakeLists.txt.

Builds upon #30992, #31020

Cherry pick of #31234 (39ddc67)

Addresses rdar://62245784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants