Skip to content

[5.3][build] copy Python detection code into StandaloneOverlays.cmake #31235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2020
Merged

[5.3][build] copy Python detection code into StandaloneOverlays.cmake #31235

merged 2 commits into from
Apr 23, 2020

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Apr 23, 2020 •
edited
Loading

This is to support workflows that do not rely on reading the main
CMakeLists.txt.

Based upon #30992, #31020

Addresses rdar://62245784

(cherry picked from commit 7bc15b8)

@edymtt
[build] refactor Python detection code
2e922e0 
Move detection of Python code into dedicate CMake module, so it can be
reused for workflows that do not rely on reading the main
`CMakeLists.txt`.

Builds upon swiftlang#30992, swiftlang#31020

Addresses rdar://62245784

(cherry picked from commit 7bc15b8)
@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please smoke test

@edymtt edymtt changed the title [build] refactor Python detection code [5.3][build] refactor Python detection code Apr 23, 2020
@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

This is cherry-picked from #31234

@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please test Windows

compnerd
compnerd requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments on #31234

@edymtt
Remove FindPython.cmake, duplicate code in StandaloneOverlays.cmake
b24dd80 
As per review feedback.

(cherry picked from commit 98a3b55)
@edymtt edymtt changed the title [5.3][build] refactor Python detection code [5.3][build] copy Python detection code into StandaloneOverlays.cmake Apr 23, 2020
@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2e922e0

@edymtt edymtt requested a review from compnerd April 23, 2020 15:31
@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please test macOS

@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please test Windows

1 similar comment
@edymtt
Copy link
Contributor Author

edymtt commented Apr 23, 2020

@swift-ci please test Windows

@compnerd compnerd added the r5.3 label Apr 23, 2020
@edymtt edymtt merged commit a032507 into swiftlang:release/5.3 Apr 23, 2020
@edymtt edymtt deleted the refactor_python_detection_logic_5_3 branch April 23, 2020 18:55
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

@clackary clackary Awaiting requested review from clackary

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edymtt @swift-ci @compnerd @AnthonyLatsis