Skip to content

[CodeCompletion] Fix a crash in context type analysis for tuple expr #31073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 16, 2020

When completing inside tuple expressions, the context tuple type may have fewer number of elements. In such cases, we cannot provide the expected type.

rdar://problem/61668779

When completing inside tuple expressions, the context tuple type may
have fewer number of elements. In such cases, we cannot provide the
expected type.

rdar://problem/61668779
@rintaro
Copy link
Member Author

rintaro commented Apr 16, 2020

@swift-ci Please smoke test

@rintaro rintaro requested a review from benlangmuir April 16, 2020 16:46
Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@rintaro rintaro merged commit 5b91742 into swiftlang:master Apr 16, 2020
@rintaro rintaro deleted the ide-completion-analyzetuple-rdar61668779 branch April 16, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants