[5.2][CodeCompletion] Fix a crash in context type analysis for tuple expr #31079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
akyrtzi
approved these changes
Apr 16, 2020
rintaro
changed the title
|
Build failed |
|
Build failed |
When completing inside tuple expressions, the context tuple type may have fewer number of elements. In such cases, we cannot provide the expected type. rdar://problem/61668779 (cherry picked from commit 47e303a)
rintaro
force-pushed
the
5.2-ide-completion-analyzetuple-rdar61668779
branch
from
45713f7 to
6e8424a
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test Linux |
AnthonyLatsis
added
swift 5.2
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-pick of #31073 to swift-5.2-branch)
When completing inside tuple expressions, the context tuple type may have fewer number of elements. In such cases, we cannot provide the expected type.
rdar://problem/61902917