[NFC] [SIL] [Parser] Move SILParserTUState into SILParserState.h #31254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
force-pushed
the
sil-parser/sil-parser-state-header
branch
from
c6a5b30 to
8622101
Compare
gottesmm
reviewed
Apr 24, 2020
lib/SIL/Parser/SILParserState.h
Outdated
|
|
||
| // This has to be in the 'swift' namespace because it's forward-declared for | ||
| // SILParserState. | ||
| class SILParserTUState : public SILParserTUStateBase { |
There was a problem hiding this comment.
Lets make this even clearer. SILParserTranslationUnitState.h.
There was a problem hiding this comment.
Thanks for the review! Renamed to SILParserTranslationUnitState.h. The other PR is updated too.
zoecarver
force-pushed
the
sil-parser/sil-parser-state-header
branch
from
8622101 to
4a28842
Compare
|
@gottesmm ping. |
hamishknight
reviewed
Oct 7, 2020
zoecarver
force-pushed
the
sil-parser/sil-parser-state-header
branch
from
acfbc62 to
074375e
Compare
|
Thanks @hamishknight. All comments have been resolved. |
lib/SIL/Parser/SILParserState.h
Outdated
| @@ -0,0 +1,61 @@ | |||
| //===--- SILParserState.h - SILParserState declaraion -------------------===// | |||
There was a problem hiding this comment.
Small typo: declaraion
Moves the declaration of SILParserTUState into a new private header file: SILParserState.h
zoecarver
force-pushed
the
sil-parser/sil-parser-state-header
branch
from
074375e to
dfc5c70
Compare
|
@swift-ci please smoke test and merge. |
1 similar comment
|
@swift-ci please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the declaration of SILParserTUState into a new private header file: SILParserState.h. This is a simple cut and paste so there should be no functional changes.