Fix ReactiveKit failure seen in source compatibility suite #31288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master source compat suite job swiftlang#4912 failed to build ReactiveKit because Combine does not have an interface for older iOS architectures that were retired before it was released, and a change to module loading diagnosis started to consider switfinterfaces. Add a test case that covers this situation.
…ith wrong arch." This reverts commit 412ee0a.
|
@swift-ci smoke test |
|
😢 |
|
Oh well, that's unfortunate. 😢 |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the commits in #31196 caused a regression when
canImport()was used to test the importability of a module which has module interfaces for other targets, but not the current one. In practice, this happens with Combine and other iOS 13-introduced modules, because they don't have module interface files for 32-bit ARM.The right solution is to refactor diagnosis during module loading so that we can guarantee that
canImport()won't diagnose anything, but this PR simply adds a similar test case and reverts the commit to fix the broken bot.Fixes rdar://62335415.