Skip to content

[ownership] Accept unconditional_checked_cast_addr, treating it like a write. #31421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

Just missed this on my first pass through.

rdar://62609950

…a write.

Just missed this on my first pass through.

rdar://62609950
@gottesmm gottesmm requested a review from atrick April 29, 2020 22:27
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

@gottesmm
Copy link
Contributor Author

@compnerd this is failing due to a problem on the windows infrastructure.

S:\jenkins\workspace\swift-PR-windows\llvm\lib\Analysis\PhiValues.cpp(228): fatal error C1069: cannot read compiler command line

Merging!

@gottesmm gottesmm merged commit 4a4b7bf into swiftlang:master Apr 30, 2020
@gottesmm gottesmm deleted the pr-9a4e0a7a57d7bd503205a207da15b89babf064d6 branch April 30, 2020 00:31
@compnerd
Copy link
Member

You could have just rerun the CI ;)

@gottesmm
Copy link
Contributor Author

@compnerd I think I did. It failed twice.

@gottesmm
Copy link
Contributor Author

But maybe my memory is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants