Skip to content

[ownership] Accept unconditional_checked_cast_addr, treating it like a write. #31421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/SIL/Verifier/LoadBorrowInvalidationChecker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,12 @@ constructValuesForKey(SILValue initialValue,
continue;
}

// unconditional_checked_cast_addr does a take on its input memory.
if (isa<UnconditionalCheckedCastAddrInst>(user)) {
wellBehavedWriteAccumulator.push_back(op);
continue;
}

if (auto *ccabi = dyn_cast<CheckedCastAddrBranchInst>(user)) {
if (ccabi->getConsumptionKind() != CastConsumptionKind::CopyOnSuccess) {
wellBehavedWriteAccumulator.push_back(op);
Expand Down
103 changes: 103 additions & 0 deletions test/SIL/ownership-verifier/load_borrow_invalidation_test.sil
Original file line number Diff line number Diff line change
Expand Up @@ -272,3 +272,106 @@ bb0(%0 : $Builtin.RawPointer):
%9999 = tuple()
return %9999 : $()
}

////////////////////////
// Address Cast Tests //
////////////////////////

sil [ossa] @unconditional_checked_cast_addr_test : $@convention(thin) (@in Builtin.NativeObject) -> () {
bb0(%0 : $*Builtin.NativeObject):
%0a = load_borrow %0 : $*Builtin.NativeObject
end_borrow %0a : $Builtin.NativeObject

%stack0 = alloc_stack $Builtin.NativeObject
unconditional_checked_cast_addr Builtin.NativeObject in %0 : $*Builtin.NativeObject to Builtin.NativeObject in %stack0 : $*Builtin.NativeObject
destroy_addr %stack0 : $*Builtin.NativeObject
dealloc_stack %stack0 : $*Builtin.NativeObject
%9999 = tuple()
return %9999 : $()
}

sil [ossa] @conditional_addr_cast_always_take : $@convention(thin) (@in Builtin.NativeObject) -> () {
bb0(%0 : $*Builtin.NativeObject):
%0a = load_borrow %0 : $*Builtin.NativeObject
end_borrow %0a : $Builtin.NativeObject

%stack0 = alloc_stack $Builtin.NativeObject
checked_cast_addr_br take_always Builtin.NativeObject in %0 : $*Builtin.NativeObject to Builtin.NativeObject in %stack0 : $*Builtin.NativeObject, bb1, bb2

bb1:
br bb3

bb2:
br bb3

bb3:
destroy_addr %stack0 : $*Builtin.NativeObject
dealloc_stack %stack0 : $*Builtin.NativeObject
%9999 = tuple()
return %9999 : $()
}

sil [ossa] @conditional_addr_cast_take_on_success : $@convention(thin) (@in Builtin.NativeObject) -> () {
bb0(%0 : $*Builtin.NativeObject):
%0a = load_borrow %0 : $*Builtin.NativeObject
end_borrow %0a : $Builtin.NativeObject

%stack0 = alloc_stack $Builtin.NativeObject
checked_cast_addr_br take_on_success Builtin.NativeObject in %0 : $*Builtin.NativeObject to Builtin.NativeObject in %stack0 : $*Builtin.NativeObject, bb1, bb2

bb1:
destroy_addr %stack0 : $*Builtin.NativeObject
br bb3

bb2:
br bb3

bb3:
dealloc_stack %stack0 : $*Builtin.NativeObject
%9999 = tuple()
return %9999 : $()
}

sil [ossa] @conditional_addr_cast_copyonsuccess_1 : $@convention(thin) (@in Builtin.NativeObject) -> () {
bb0(%0 : $*Builtin.NativeObject):
%0a = load_borrow %0 : $*Builtin.NativeObject
end_borrow %0a : $Builtin.NativeObject

%stack0 = alloc_stack $Builtin.NativeObject
checked_cast_addr_br copy_on_success Builtin.NativeObject in %0 : $*Builtin.NativeObject to Builtin.NativeObject in %stack0 : $*Builtin.NativeObject, bb1, bb2

bb1:
destroy_addr %stack0 : $*Builtin.NativeObject
br bb3

bb2:
br bb3

bb3:
dealloc_stack %stack0 : $*Builtin.NativeObject
destroy_addr %0 : $*Builtin.NativeObject
%9999 = tuple()
return %9999 : $()
}

sil [ossa] @conditional_addr_cast_copyonsuccess_2 : $@convention(thin) (@in Builtin.NativeObject) -> () {
bb0(%0 : $*Builtin.NativeObject):
%0a = load_borrow %0 : $*Builtin.NativeObject

%stack0 = alloc_stack $Builtin.NativeObject
checked_cast_addr_br copy_on_success Builtin.NativeObject in %0 : $*Builtin.NativeObject to Builtin.NativeObject in %stack0 : $*Builtin.NativeObject, bb1, bb2

bb1:
destroy_addr %stack0 : $*Builtin.NativeObject
br bb3

bb2:
br bb3

bb3:
dealloc_stack %stack0 : $*Builtin.NativeObject
end_borrow %0a : $Builtin.NativeObject
destroy_addr %0 : $*Builtin.NativeObject
%9999 = tuple()
return %9999 : $()
}