[5.3][Property Wrappers] For now, don't allow wrappedValue and projectedValue to have dynamic Self type. #31427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to have dynamic Self type.
|
@swift-ci please test |
slavapestov
reviewed
Apr 30, 2020
| @@ -2862,7 +2862,7 @@ void AttributeChecker::visitCustomAttr(CustomAttr *attr) { | |||
|
|
|||
| // If the nominal type is a property wrapper type, we can be delegating | |||
| // through a property. | |||
| if (nominal->getPropertyWrapperTypeInfo()) { | |||
| if (nominal->getAttrs().hasAttribute<PropertyWrapperAttr>()) { | |||
There was a problem hiding this comment.
What does this change do? I’m not objecting, just curious
There was a problem hiding this comment.
This change only suppresses the cannot be used as attribute diagnostic in the case where the nominal type for the custom attribute type is declared as @propertyWrapper but there's some other error, such as the type not having a non-static wrappedValue property
hborla
changed the title
wrappedValue/projectedValue to also cover optional.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
DougGregor
approved these changes
May 1, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #31344 and it's follow-up #31443
Currently, when wrappedValue or projectedValue have dynamic Self type, the synthesized properties when using the wrapper will also get a dynamic Self type, but in a new context. This bug could manifest as really misleading diagnostics, or a crash. For now, we will disallow this, but we can re-visit implementing correct support for this in the future.
Resolves: rdar://problem/53258469