Skip to content

[Property Wrappers] Fix disallowing dynamic Self for property wrapper wrappedValue/projectedValue to also cover optional. #31443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Apr 30, 2020

This is a follow up to #31344 to also cover Self?.

I left the error message the same because any use of dynamic self other than Self and Self? will be diagnosed with Covariant 'Self' can only appear at the top level of property type.

wrappedValue/projectedValue to also cover optional.
@hborla hborla requested a review from slavapestov April 30, 2020 16:08
@hborla
Copy link
Member Author

hborla commented Apr 30, 2020

@swift-ci please smoke test

Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hborla hborla merged commit 259a88e into swiftlang:master Apr 30, 2020
@hborla hborla deleted the property-wrapper-optional-dynamic-self branch April 30, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants