Add new cast pattern in SILCombine #31595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
reviewed
May 6, 2020
|
@swift-ci test |
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@meg-gupta can you make sure to squash this before you land it/give it a nice commit message. The commit history is the narrative that we leave for our future selves! |
gottesmm
reviewed
May 7, 2020
gottesmm
reviewed
May 7, 2020
|
I'll update the FileCheck changes. And will squash merge. |
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test |
…atype conversions Add pattern to catch the following redundant conversion: %tmp1 = thick_to_objc_metatype %x %tmp2 = objc_to_thick_metatype %tmp1 ... %tmp3 = <sil operation> %tmp2 to: %tmp3 = <sil operation> %x Similarly add pattern for redundant conversion of objc_to_thick_metatype followed by thick_to_objc_metatype. Fixes rdar://62932799
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test |
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
May 12, 2020
Add new pattern in SILCombine to optimize redundant thick to objc metatype conversions Add pattern to catch the following redundant conversion: %tmp1 = thick_to_objc_metatype %x %tmp2 = objc_to_thick_metatype %tmp1 ... %tmp3 = <sil operation> %tmp2 to: %tmp3 = <sil operation> %x Similarly add pattern for redundant conversion of objc_to_thick_metatype followed by thick_to_objc_metatype. Fixes rdar://62932799
meg-gupta
added a commit
that referenced
this pull request
May 12, 2020
Add new pattern in SILCombine to optimize redundant thick to objc metatype conversions Add pattern to catch the following redundant conversion: %tmp1 = thick_to_objc_metatype %x %tmp2 = objc_to_thick_metatype %tmp1 ... %tmp3 = <sil operation> %tmp2 to: %tmp3 = <sil operation> %x Similarly add pattern for redundant conversion of objc_to_thick_metatype followed by thick_to_objc_metatype. Fixes rdar://62932799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pattern to catch the following redundant conversion:
%tmp1 = thick_to_objc_metatype %x%tmp2 = objc_to_thick_metatype %tmp1...
%tmp3 = <sil operation> %tmp2to:
%tmp3 = <sil operation> %xSimilarly add pattern for redundant conversion of
objc_to_thick_metatypefollowed by
thick_to_objc_metatype.Fixes rdar://62932799