Recommit #31595 with fixes #31732
Merged
Recommit #31595 with fixes #31732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new pattern in SILCombine to optimize redundant thick to objc metatype conversions Add pattern to catch the following redundant conversion: %tmp1 = thick_to_objc_metatype %x %tmp2 = objc_to_thick_metatype %tmp1 ... %tmp3 = <sil operation> %tmp2 to: %tmp3 = <sil operation> %x Similarly add pattern for redundant conversion of objc_to_thick_metatype followed by thick_to_objc_metatype. Fixes rdar://62932799
|
@swift-ci please asan test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new pattern in SILCombine to optimize redundant thick to objc metatype conversions
Add pattern to catch the following redundant conversion:
%tmp1 = thick_to_objc_metatype %x%tmp2 = objc_to_thick_metatype %tmp1...
%tmp3 = <sil operation> %tmp2to:
%tmp3 = <sil operation> %xSimilarly add pattern for redundant conversion of
objc_to_thick_metatypefollowed by
thick_to_objc_metatype.Fixes rdar:///63135437