[SIL] [Parser] Move type parser out of ParseSIL. #31855
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
force-pushed
the
sil-parser/type-parser
branch
from
3f92d25 to
968518a
Compare
|
Converting to a draft until I figure out why this is causing segfaults. |
Isolates the SILType parsing logic.
zoecarver
force-pushed
the
sil-parser/type-parser
branch
from
968518a to
23921aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the type parsing logic out of
SILParser. After this and #31255 land I have another patch to move instruction parsing out ofSILParser. The instruction parsing can have its own copy of this object.This is a NFC.