Consolidated four CoreGraphics execution tests #31859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
force-pushed
the
merge-coregraphics
branch
from
8faccb0 to
dea4294
Compare
gribozavr
force-pushed
the
merge-coregraphics
branch
from
dea4294 to
b15268a
Compare
gribozavr
changed the title
gribozavr
force-pushed
the
merge-coregraphics
branch
2 times, most recently
from
a14d68b to
977d25e
Compare
CodaFi
approved these changes
May 18, 2020
gribozavr
force-pushed
the
merge-coregraphics
branch
from
977d25e to
9d52769
Compare
I don't see any reason to split the tests like this. I merged the tests into the biggest and best-organized test file. I also removed the `REQUIRES: OS=macosx` line and made some small adjustments to the test to make it cross-platform.
gribozavr
force-pushed
the
merge-coregraphics
branch
from
9d52769 to
30afc6c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reason to split the tests like this. I merged the tests into the biggest and best-organized test file.
I also removed the
REQUIRES: OS=macosxline from the test because CoreGraphics API should be available on all platforms.