[Diagnostics] Add -diagnostic-style=(llvm|swift) to control printed output #32017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput This default formatting style remains the same "LLVM style". "Swift style" is what was previously enabled via -enable-experimental-diagnostic-formatting
|
@swift-ci smoke test |
|
Because the new style isn't the default this isn't a huge change, but it could potentially impact editors that parse the old style, so let me know if any of you have concerns about making it generally available. Once this lands I'm going to post on the forums and see if anyone has strong opinions about the design after trying it out. |
xedin
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default formatting style remains the same, "LLVM style". "Swift style"
is what was previously enabled via -enable-experimental-diagnostic-formatting
#31213 has some screenshots of the new style. I'm not making it the default because I want to gather some feedback from real-world use first.