runtime: further isolate runtime from LLVMSupport #32066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @mikeash |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
This cleans up some more `llvm::` leakage in the runtime when built into a static library. With this change we are down to 3 leaking symbols in the static library related to a missed ADT (`StringSwitch`).
mikeash
approved these changes
May 28, 2020
compnerd
force-pushed
the
small-change-for-small-vector
branch
from
09c559c to
c050a26
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
ematejska
pushed a commit
that referenced
this pull request
May 29, 2020
runtime: further isolate runtime from LLVMSupport
ematejska
pushed a commit
that referenced
this pull request
May 29, 2020
runtime: further isolate runtime from LLVMSupport
ematejska
pushed a commit
that referenced
this pull request
May 29, 2020
runtime: further isolate runtime from LLVMSupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some more
llvm::leakage in the runtime when built intoa static library. With this change we are down to 3 leaking symbols in
the static library related to a missed ADT (
StringSwitch).Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.