test: add a ODR violation check for the static standard library #32078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Linux platform |
|
CC: @mikeash |
|
Build failed |
mikeash
approved these changes
May 29, 2020
|
@swift-ci please test |
|
Build failed |
The static version of the standard library was leaking symbols in the `llvm::` namespace which would result in ODR violations were the artifact linking against `LLVMSupport` (via another dependency). In particular, `llvm::SmallVector` and `llvm::StringSwitch` symbols were being leaked. This adds a test case specifically for the static variant of the library. The dynamic variant of the library is already tested in a separate test.
compnerd
force-pushed
the
if-it-isnt-tested-its-broken
branch
from
171405a to
63c8c00
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static version of the standard library was leaking symbols in the
llvm::namespace which would result in ODR violations were theartifact linking against
LLVMSupport(via another dependency). Inparticular,
llvm::SmallVectorandllvm::StringSwitchsymbols werebeing leaked. This adds a test case specifically for the static variant
of the library. The dynamic variant of the library is already tested in
a separate test.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.