[cxx-interop] Add support for C++ comparison operators. #32351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
MForster
reviewed
Jun 15, 2020
| case clang::OverloadedOperatorKind::OO_EqualEqual: | ||
| case clang::OverloadedOperatorKind::OO_ExclaimEqual: | ||
| case clang::OverloadedOperatorKind::OO_LessEqual: | ||
| case clang::OverloadedOperatorKind::OO_GreaterEqual: |
There was a problem hiding this comment.
Can we keep this list (and also the test cases) in the same order as https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Basic/OperatorKinds.def#L58,L104?
There was a problem hiding this comment.
Good idea. I did this as a separate commit.
gribozavr
approved these changes
Jun 15, 2020
Adds support for C++ operators: `<`, `>`, `==`, `!=`, `<=`, and `>=`.
Re-order operator case statements and tests. The order now follows the order defined in `llvm-project/clang/include/clang/Basic/OperatorKinds.def`. Also, adds operator character(s) in parentheses.
zoecarver
force-pushed
the
cxx/compare-op
branch
from
f4755c5 to
3a23e08
Compare
|
@swift-ci please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for C++ operators:
<,>,==,!=,<=, and>=.