[Sema] Only require a default implementation for SPI requirements in non-SPI protocols #32793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
xymus
force-pushed
the
spi-req-in-spi-proto
branch
from
878cc32 to
4f55a02
Compare
|
@swift-ci Please smoke test |
xymus
changed the title
xymus
changed the title
beccadax
approved these changes
Jul 9, 2020
slavapestov
reviewed
Jul 10, 2020
lib/Sema/TypeCheckAttr.cpp
Outdated
| extension->isConstrainedExtension()) | ||
| return false; | ||
| if (!protocol->isSPI()) { | ||
| auto implementations = TypeChecker::lookupMember( |
There was a problem hiding this comment.
This should reuse the existing logic for finding default implementations instead of rolling its own.
There was a problem hiding this comment.
More specifically I think these checks could be moved to typechecker::inferDefaultWitnesses().
There was a problem hiding this comment.
Thank you for pointing this out. I moved the check and it is much cleaner!
Asides from removing duplicated code this change also now checks implicit SPI requirements and applies only in library evolution mode.
…ntation The check for SPI protocol requirements needing a default implementation should ignore requirements in a protocol that is SPI too. The protocol can’t be conformed to without knowing of the requirement. rdar://65286171
xymus
force-pushed
the
spi-req-in-spi-proto
branch
from
4f55a02 to
d70b0c9
Compare
|
Moved the check to TypeCheckProtocol with pre-existing logic. I'll have to spend more time on the runtime test. It works as expected with library evolution but it crashes in an ugly way without it when rebuilding from the public swiftinterface. @swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for SPI protocol requirements needing a default implementation should ignore requirements in a protocol that is SPI too. The protocol can’t be conformed to without knowing of the requirement.
rdar://65286171