[5.3][Sema] Only require a default implementation for SPI requirements in non-SPI protocols #32883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asides from removing duplicated code this change also now checks implicit SPI requirements and applies only in library evolution mode.
…ntation The check for SPI protocol requirements needing a default implementation should ignore requirements in a protocol that is SPI too. The protocol can’t be conformed to without knowing of the requirement. rdar://65286171
|
@swift-ci Please test |
|
@swift-ci Please nominate |
nkcsgexi
approved these changes
Jul 15, 2020
devincoughlin
approved these changes
Jul 15, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An SPI protocol requirement needs a default implementation unless the protocol is SPI too. The current check didn't take into account the protocol SPI status. It was usually fine in hand written source code but it breaks on the private swiftinterface files where the
@_spiattribute is printed explicitly.