[SourceKit] Fix issue where CompletionCheckDependencyInterval is set to 0 when the global config request is sent
#33198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to 0 when the global config request is sent Fixes rdar://66309544
|
@swift-ci smoke test |
rintaro
reviewed
Jul 30, 2020
Comment on lines
-445
to
+447
| Optional<unsigned> CompletionCheckDependencyInterval; | ||
| int64_t IntervalValue = 0; | ||
| if (!Req.getInt64(KeyCompletionCheckDependencyInterval, | ||
| IntervalValue, /*isOptional=*/true)) | ||
| CompletionCheckDependencyInterval = IntervalValue; | ||
| Optional<unsigned> CompletionCheckDependencyInterval = | ||
| Req.getOptionalInt64(KeyCompletionCheckDependencyInterval) | ||
| .map([](int64_t v)->unsigned{return v;}); |
There was a problem hiding this comment.
Just to clarify, should rewriting /*isOptional=*/true to /*isOptional=*/false in the original code also fix the issue?
There was a problem hiding this comment.
Yes, but getOptionalInt64() is more readable. I have to admit that getInt64() is not well thought out as an API and rife for confusion, as in this case.
There was a problem hiding this comment.
Thanks! I agree getOptionalInt64() is more readable.
rintaro
approved these changes
Jul 30, 2020
|
@swift-ci smoke test OS X platform |
|
@swift-ci Please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://66309544