Skip to content

[5.3][SourceKit] Fix issue where CompletionCheckDependencyInterval is set to 0 when the global config request is sent #33209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

[5.3][SourceKit] Fix issue where CompletionCheckDependencyInterval is set to 0 when the global config request is sent #33209

merged 1 commit into from
Jul 30, 2020

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Jul 30, 2020 •
edited
Loading

master: #33198

  • Explanation: Fast completion mode was intended to check dependencies after a delay, to avoid doing lots of I/O stat calls for every completion invocation. But by mistake the delay was unintentionally set to '0' when a 'global config' request is sent by the client, meaning this default optimization for delaying the I/O checks is not enabled when using completion in Xcode.
  • Scope: SourceKit completion
  • Risk: Very low. Simple targeted fix.
  • Testing: Added regression test.
  • Issue: rdar://66309544
  • Reviewer: @rintaro

@akyrtzi
[SourceKit] Fix issue where CompletionCheckDependencyInterval is se…
3700edb 
…t to 0 when the global config request is sent

Fixes rdar://66309544
@akyrtzi akyrtzi requested a review from a team as a code owner July 30, 2020 17:06
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Jul 30, 2020

@swift-ci Please test

@akyrtzi akyrtzi added the r5.3 label Jul 30, 2020
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Jul 30, 2020

@swift-ci please nominate

@akyrtzi akyrtzi merged commit 9b9f6dc into swiftlang:release/5.3 Jul 30, 2020
@akyrtzi akyrtzi deleted the 5.3-fast-completion-depend-check-delay branch July 30, 2020 19:38
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akyrtzi @AnthonyLatsis