Add functionality that returns correct reflection section name for different object files (Mach-O, ELF, COFF) #33358
Conversation
augusto2112
force-pushed
the
reflection-section-constants
branch
from
63cf87f to
5dc3bc9
Compare
|
Thanks! This was long overdue. |
augusto2112
force-pushed
the
reflection-section-constants
branch
from
5dc3bc9 to
27a3e3f
Compare
|
@adrian-prantl Do you have any suggestions for the naming |
Perhaps SwiftObjectFileFormat, SwiftObjectFileFormatELF, ... at the call site that would look like: SwiftObjectFileFormatELF::getSectionName(SwiftObjectFileFormat::SectionKind::typeref) ? |
|
@swift-ci smoke test |
|
@augusto2112 are you planning to rename this still? |
|
@adrian-prantl I am! It looks like something here, together with the other patch, is causing some bug that makes the test fail (the other patch by itself works though). I'm trying to understand what's happening before pushing the changes. |
augusto2112
force-pushed
the
reflection-section-constants
branch
from
27a3e3f to
70d002f
Compare
|
@adrian-prantl Found it. Could you re-start the tests? They were going to fail for sure with the previous commit. |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@adrian-prantl don't merge yet please, I haven't renamed the enum yet. I'm also surprised the tests passed this time, since I didn't commit anything between the smoke tests. |
…fferent object files
|
@adrian-prantl Ok, done! |
augusto2112
force-pushed
the
reflection-section-constants
branch
from
70d002f to
34c55e2
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
Linux error seems unrelated (SwiftPM error): |
|
@swift-ci smoke test |
|
@augusto2112 Can you cherry-pick this to master-next, too? |
This is used by swiftlang/llvm-project#1608 in order to get the correct reflection section name.
@adrian-prantl @vedantk