Skip to content

Use new libReflection API when reading ELF files #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

augusto2112
Copy link

@augusto2112 augusto2112 commented Aug 6, 2020

This PR uses the updated readELF API (implemented in swiftlang/swift#33321) when setting up reflection from ELF files.

Also depends on swiftlang/swift#33358.

@adrian-prantl @vedantk

@augusto2112 augusto2112 force-pushed the read-elf-sections branch 2 times, most recently from aa47a03 to 9ad265c Compare August 7, 2020 19:48
@adrian-prantl
Copy link

test with swiftlang/swift#33358
@swift-ci test

@adrian-prantl
Copy link

test with swiftlang/swift#33358
@swift-ci test

@augusto2112
Copy link
Author

@adrian-prantl I just pushed, could you re-run? This PR actually depends on both swiftlang/swift#33358 and swiftlang/swift#33321 though.

@adrian-prantl
Copy link

test with swiftlang/swift#33358
@swift-ci test

@adrian-prantl
Copy link

@swift-ci smoke test

@augusto2112
Copy link
Author

Maybe it failed because swiftlang/swift#33358 was already merged?

20:19:59 /Users/buildnode/jenkins/workspace/apple-llvm-project-pr-macos/swift
20:19:59 fatal: couldn't find remote ref pull/33358/merge

Could you test with swiftlang/swift#33321?

@adrian-prantl
Copy link

@swift-ci smoke test

2 similar comments
@adrian-prantl
Copy link

@swift-ci smoke test

@adrian-prantl
Copy link

@swift-ci smoke test

@adrian-prantl
Copy link

@swift-ci test and merge

3 similar comments
@adrian-prantl
Copy link

@swift-ci test and merge

@adrian-prantl
Copy link

@swift-ci test and merge

@adrian-prantl
Copy link

@swift-ci test and merge

@adrian-prantl
Copy link

@swift-ci test

@augusto2112
Copy link
Author

I'm having trouble running the test locally:

error: compiled module was created by an older version of the compiler; rebuild 'Swift' and try again

I've already re-compiled the project, to no avail.

@adrian-prantl
Copy link

Failing Tests (1):
lldb-api :: lang/swift/parseable_interfaces/shared/TestSwiftInterfaceNoDebugInfo.py

@adrian-prantl
Copy link

@swift-ci test

@augusto2112
Copy link
Author

@adrian-prantl can you re-run please? Just updated rebasing on top of master.

@adrian-prantl
Copy link

@swift-ci test

@augusto2112
Copy link
Author

@adrian-prantl It failed in the same test. I can't test it locally right now because of an error that's different from the CI one:

error: /home/augusto/developer/swift-project/build/Ninja-ReleaseAssert/lldb-linux-x86_64/lldb-test-build.noindex/lang/swift/parseable_interfaces/shared/TestSwiftInterfaceNoDebugInfo.test_swift_interface_dwarf/AA.swiftinterface:1:1: error: failed to build module 'AA' from its module interface; it may have been damaged or it may have triggered a bug in the Swift compiler when it was produced
// swift-interface-format-version: 1.0
^

error: compiled module was created by an older version of the compiler; rebuild 'Swift' and try again: /home/augusto/developer/swift-project/build/Ninja-ReleaseAssert/lldb-linux-x86_64/lib/lldb/swift/linux/x86_64/Swift.swiftmodule

Only 7 tests in API/lang/swift are passing in my machine right now, for some reason. I'm re-cloning and re-building from scratch to see if that fixes it.

@adrian-prantl
Copy link

Ninja-ReleaseAssert/lldb-linux-x86_64/lldb-test-build.noindex/lang/swift/parseable_interfaces/shared/TestSwiftInterfaceNoDebugInfo.test_swift_interface_dwarf/AA.swiftinterface:1:1: error: failed to build module 'AA' from its module interface; it may have been damaged or it may have triggered a bug in the Swift compiler when it was produced
// swift-interface-format-version: 1.0
^

error: compiled module was created by an older version of the compiler; rebuild 'Swift' and try again: /home/augusto/developer/swift-project/build/Ninja-ReleaseAssert/lldb-linux-x86_64/lib/lldb/swift/linux/x86_64/Swift.swiftmodule

Can you try deleting /home/augusto/developer/swift-project/build/Ninja-ReleaseAssert/lldb-linux-x86_64 and re-running build-script?

@adrian-prantl
Copy link

test with swiftlang/swift#33434
@swift-ci test

@augusto2112
Copy link
Author

It looks like the test is stuck.

@adrian-prantl
Copy link

@swift-ci test

@adrian-prantl
Copy link

@shahmishal The tests appear to be stuck and the "Details" link resolves to a gateway error right now. Do you know how to get them running again?

@augusto2112
Copy link
Author

@adrian-prantl Could you try restarting this one more time please?

@augusto2112
Copy link
Author

@adrian-prantl Ok, it looks like the tests finally ran, but checked out swift//master instead of my pr (swiftlang/swift#33434):

10:40:32 ++ /home/buildnode/jenkins/workspace/apple-llvm-project-pr-linux/swift/utils/update-checkout --clean --reset-to-remote --clone --scheme swift/master --skip-repository llvm-project --github-comment '@adrian-prantl Could you try restarting this one more time please?'

@adrian-prantl
Copy link

test with swiftlang/swift#33434
@swift-ci test

@adrian-prantl
Copy link

My mistake. Sorry!

@adrian-prantl
Copy link

@swift-ci test

@adrian-prantl
Copy link

@swift-ci smoke test

@adrian-prantl
Copy link

@swift-ci test

@adrian-prantl
Copy link

@swift-ci test

@adrian-prantl adrian-prantl merged commit 454d680 into swiftlang:swift/master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants