-
Notifications
You must be signed in to change notification settings - Fork 342
Use new libReflection API when reading ELF files #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new libReflection API when reading ELF files #1608
Conversation
lldb/test/API/lang/swift/parseable_interfaces/shared/TestSwiftInterfaceNoDebugInfo.py
Show resolved
Hide resolved
eee5b02
to
1849327
Compare
aa47a03
to
9ad265c
Compare
9ad265c
to
188de2b
Compare
test with swiftlang/swift#33358 |
test with swiftlang/swift#33358 |
188de2b
to
e0135ad
Compare
@adrian-prantl I just pushed, could you re-run? This PR actually depends on both swiftlang/swift#33358 and swiftlang/swift#33321 though. |
test with swiftlang/swift#33358 |
@swift-ci smoke test |
Maybe it failed because swiftlang/swift#33358 was already merged?
Could you test with swiftlang/swift#33321? |
@swift-ci smoke test |
@swift-ci test and merge |
@swift-ci test |
I'm having trouble running the test locally:
I've already re-compiled the project, to no avail. |
Failing Tests (1): |
@swift-ci test |
e0135ad
to
ffea3c8
Compare
@adrian-prantl can you re-run please? Just updated rebasing on top of master. |
@swift-ci test |
@adrian-prantl It failed in the same test. I can't test it locally right now because of an error that's different from the CI one:
Only 7 tests in API/lang/swift are passing in my machine right now, for some reason. I'm re-cloning and re-building from scratch to see if that fixes it. |
Can you try deleting |
ffea3c8
to
82f6b31
Compare
test with swiftlang/swift#33434 |
It looks like the test is stuck. |
@swift-ci test |
@shahmishal The tests appear to be stuck and the "Details" link resolves to a gateway error right now. Do you know how to get them running again? |
@adrian-prantl Could you try restarting this one more time please? |
@adrian-prantl Ok, it looks like the tests finally ran, but checked out swift//master instead of my pr (swiftlang/swift#33434):
|
test with swiftlang/swift#33434 |
My mistake. Sorry! |
@swift-ci test |
82f6b31
to
53be54f
Compare
@swift-ci smoke test |
@swift-ci test |
4173610
to
a046f43
Compare
@swift-ci test |
This PR uses the updated
readELF
API (implemented in swiftlang/swift#33321) when setting up reflection from ELF files.Also depends on swiftlang/swift#33358.
@adrian-prantl @vedantk