Fix reading elf section from file buffer #33434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
|
@swift-ci smoke test Linux |
augusto2112
force-pushed
the
read-elf-sections-fix
branch
from
820eac2 to
d2e1626
Compare
|
@adrian-prantl all checks passed, but I double-checked the code and there was still a possible bug there, so I had to push again. |
|
@swift-ci smoke test |
|
@adrian-prantl Some other PRs seem to have the tests running now. Could you try restarting the tests here one more time please? |
|
Actually, looks like the linux build just started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes a bug where reading elf sections from the file buffer would read less data than intended.
@adrian-prantl