Skip to content

Avoid using -sil-inline-generics and -sil-partial-specialization when building MinSizeRel stdlib to save ~15% on codesize #33444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kubamracek
Copy link
Contributor

No description provided.

… building MinSizeRel stdlib to save ~15% on codesize
@aschwaighofer
Copy link
Contributor

@swift-ci Please benchmark

@airspeedswift
Copy link
Member

I'm guessing this won't benchmark this change, since it's for a new config.

@kubamracek
Copy link
Contributor Author

@aschwaighofer any remaining concerns about this?

@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
FlattenListLoop 1633 2461 +50.7% 0.66x (?)
FlattenListFlatMap 3905 4273 +9.4% 0.91x (?)
 
Improvement OLD NEW DELTA RATIO
String.data.Medium 145 134 -7.6% 1.08x (?)

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
UTF8Decode_InitFromData_ascii_as_ascii 723 664 -8.2% 1.09x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. If generic performance becomes a concern we can revisit with a more target application of those optimizations based on annotations.

@kubamracek
Copy link
Contributor Author

Ok thanks!

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d414c3b

@kubamracek
Copy link
Contributor Author

@swift-ci please test macOS platform

@kubamracek kubamracek merged commit 7a9f894 into swiftlang:master Aug 18, 2020
@kubamracek kubamracek deleted the no-sil-flags-with-minsizerel branch August 18, 2020 03:58
edymtt added a commit to edymtt/swift that referenced this pull request Jan 15, 2025
This preserves the behavious introduced in swiftlang#33444.

Addresses rdar://142820419
edymtt added a commit to edymtt/swift that referenced this pull request Jan 15, 2025
This preserves the behaviour introduced in swiftlang#33444.

Addresses rdar://142820419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants