-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Avoid using -sil-inline-generics and -sil-partial-specialization when building MinSizeRel stdlib to save ~15% on codesize #33444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using -sil-inline-generics and -sil-partial-specialization when building MinSizeRel stdlib to save ~15% on codesize #33444
Conversation
… building MinSizeRel stdlib to save ~15% on codesize
@swift-ci Please benchmark |
I'm guessing this won't benchmark this change, since it's for a new config. |
@aschwaighofer any remaining concerns about this? |
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -OnoneCode size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. If generic performance becomes a concern we can revisit with a more target application of those optimizations based on annotations.
Ok thanks! |
@swift-ci please test |
Build failed |
@swift-ci please test macOS platform |
This preserves the behavious introduced in swiftlang#33444. Addresses rdar://142820419
This preserves the behaviour introduced in swiftlang#33444. Addresses rdar://142820419
No description provided.