[CMake] Update MinSizeRel configuration for Apple platforms... #78667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and use it as a default for one of them. Addresses rdar://142820419
This preserves the behaviour introduced in swiftlang#33444. Addresses rdar://142820419
edymtt
requested review from
etcwilde,
shahmishal,
justice-adams-apple and
compnerd
as code owners
|
@swift-ci please smoke test |
edymtt
changed the title
compnerd
approved these changes
Jan 15, 2025
etcwilde
approved these changes
Jan 15, 2025
|
|
||
| if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "MinSizeRel") | ||
| # Using these in MinSizeRel would result in a 15% increase in the binary size | ||
| target_compile_options(swiftCore PRIVATE |
There was a problem hiding this comment.
We could probably keep these in the target_compile_options above and let generator expressions handle the condition like so:
"$<$<AND:$<COMPILE_LANGUAGE:Swift>,$<NOT:$<CONFIG:MinSizeRel>>>:SHELL:-Xllvm -sil-inline-generics>"
"$<$<AND:$<COMPILE_LANGUAGE:Swift>,$<NOT:$<CONFIG:MinSizeRel>>>:SHELL:-Xllvm -sil-partial-specialization>"But I'm also not going to require that.
There was a problem hiding this comment.
Thanks for the pointer -- I searched for CMAKE_BUILD_TYPE in the documentation of the generator expressions, and I assumed it was not supported.
justice-adams-apple
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and use it as a default for one of them.
Also preserve the behaviour introduced in #33444 to avoid a binary increase in this configuration.
Addresses rdar://142820419