Skip to content

[benchmark] Add benchmark for generic floating-point to integer conversion #33895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

xwu
Copy link
Collaborator

@xwu xwu commented Sep 10, 2020

This PR adds another benchmark, this time for generic floating-point to integer conversion, in anticipation of assessing the fast path to be added in #33889.

@xwu
Copy link
Collaborator Author

xwu commented Sep 10, 2020

@swift-ci test

@xwu
Copy link
Collaborator Author

xwu commented Sep 10, 2020

@swift-ci benchmark

@swift-ci

This comment has been minimized.

@xwu
Copy link
Collaborator Author

xwu commented Sep 11, 2020

@swift-ci benchmark

@xwu xwu requested a review from eeckstein September 11, 2020 02:01
@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
Dictionary4 150 195 +30.0% 0.77x
Dictionary4OfObjects 187 230 +23.0% 0.81x
 
Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubToNSStringRef 76 68 -10.5% 1.12x (?)
 
Added MIN MAX MEAN MAX_RSS
ConvertFloatingPoint.MockFloat64ToInt64 563 570 566

Code size: -O

Regression OLD NEW DELTA RATIO
FloatingPointConversion.o 25608 27007 +5.5% 0.95x

Performance: -Osize

Regression OLD NEW DELTA RATIO
CharacterLiteralsLarge 63 71 +12.7% 0.89x
Set.subtracting.Empty.Box 8 9 +12.5% 0.89x (?)
ArrayAppendUTF16Substring 31464 34020 +8.1% 0.92x (?)
DictionaryBridgeToObjC_BulkAccess 102 110 +7.8% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
ConvertFloatingPoint.MockFloat64ToDouble 16 14 -12.5% 1.14x (?)
 
Added MIN MAX MEAN MAX_RSS
ConvertFloatingPoint.MockFloat64ToInt64 603 628 615

Code size: -Osize

Regression OLD NEW DELTA RATIO
FloatingPointConversion.o 24236 25738 +6.2% 0.94x

Performance: -Onone

Added MIN MAX MEAN MAX_RSS
ConvertFloatingPoint.MockFloat64ToInt64 52484 52559 52518

Code size: -swiftlibs

Benchmark Check Report
⚠️🔤 ConvertFloatingPoint.MockFloat64ToInt64 name is composed of 5 words.
Split ConvertFloatingPoint.MockFloat64ToInt64 name into dot-separated groups and variants. See http://bit.ly/BenchmarkNaming
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@xwu
Copy link
Collaborator Author

xwu commented Sep 11, 2020

@swift-ci test macOS platform

@xwu
Copy link
Collaborator Author

xwu commented Sep 11, 2020

@swift-ci test Linux platform

@swiftlang swiftlang deleted a comment from swift-ci Sep 11, 2020
@swiftlang swiftlang deleted a comment from swift-ci Sep 11, 2020
@xwu xwu merged commit 41d0e29 into swiftlang:master Sep 15, 2020
dabrahams pushed a commit to google/swift that referenced this pull request Sep 16, 2020
* 'master' of github.com:apple/swift:
  Fix grammatical errors (swiftlang#33940)
  [docs] Build instructions for OpenBSD. (swiftlang#33934)
  [benchmark] Add benchmark for generic floating-point to integer conversion (swiftlang#33895)
  [stdlib] Silence signaling NaN in generic conversions (swiftlang#33902)
  Introduce SymbolObjectCodeRequest
  Allow SILGen to emit only a specific set of SILDeclRefs
  Rename getFiles to getFilesToEmit
  [SILGen] Allow lazy type-checking
  [Profiler] Increment function body count prior to the prolog
  s/true/false/
  [build-script] Disable pkg-config for Darwin hosts
  build: migrate towards the unified directory layout for modules
  WinSDK: extract Internationalization submodule
  Frontend: allow directory layout for Swift on non-Darwin platforms
  [test] Fix line-directive on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants