Skip to content

[stdlib] Silence signaling NaN in generic conversions #33902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

xwu
Copy link
Collaborator

@xwu xwu commented Sep 11, 2020

This PR is a follow-up to #33826, using a cheap operation (multiplying by one) to silence signaling NaN in generic conversions.

(Mostly I'm proud of the branch name.)

@xwu
Copy link
Collaborator Author

xwu commented Sep 11, 2020

@swift-ci test

@xwu xwu requested a review from stephentyrone September 11, 2020 01:44
@stephentyrone stephentyrone merged commit 7898f0b into master Sep 15, 2020
@stephentyrone stephentyrone deleted the silence-of-the-nans branch September 15, 2020 19:05
dabrahams pushed a commit to google/swift that referenced this pull request Sep 16, 2020
* 'master' of github.com:apple/swift:
  Fix grammatical errors (swiftlang#33940)
  [docs] Build instructions for OpenBSD. (swiftlang#33934)
  [benchmark] Add benchmark for generic floating-point to integer conversion (swiftlang#33895)
  [stdlib] Silence signaling NaN in generic conversions (swiftlang#33902)
  Introduce SymbolObjectCodeRequest
  Allow SILGen to emit only a specific set of SILDeclRefs
  Rename getFiles to getFilesToEmit
  [SILGen] Allow lazy type-checking
  [Profiler] Increment function body count prior to the prolog
  s/true/false/
  [build-script] Disable pkg-config for Darwin hosts
  build: migrate towards the unified directory layout for modules
  WinSDK: extract Internationalization submodule
  Frontend: allow directory layout for Swift on non-Darwin platforms
  [test] Fix line-directive on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants