[NFC] Clarify import filtering logic and naming. #33986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci please test |
|
@swift-ci please clean test Windows |
|
@swift-ci please clean test Windows |
|
The Windows failure is because Windows doesn't support cross-repository testing. |
xymus
approved these changes
Sep 18, 2020
beccadax
approved these changes
Sep 21, 2020
varungandhi-apple
force-pushed
the
vg-import-filter-cleanup
branch
from
af58ac7 to
62ed9c8
Compare
The lack of clarity manifested as unexpected behavior when using getImportedModules to create the module import graph. The new behavior makes SPI-ness and Shadowing-ness behave similarly in terms of filtering. We also check if a filter is well-formed to avoid accidental empty import lists.
varungandhi-apple
force-pushed
the
vg-import-filter-cleanup
branch
from
62ed9c8 to
4b5d885
Compare
|
@swift-ci please test |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into surprising behavior with
SourceFile::getImportedModuleswhen working on #33980, figured I should land this first.I don't understand why
ModuleFile::getImportedModulesdoesn't have handling forSPI/ShadowedByCrossImportOverlaythough, so I haven't touched it.