Skip to content

Revert "[NFC] Clarify semantics of getImportedModules." #34410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

Revert "[NFC] Clarify semantics of getImportedModules." #34410

merged 1 commit into from
Oct 26, 2020

Conversation

varungandhi-apple
Copy link
Contributor

This reverts commit 4b5d885.

Fixes rdar://70448782.

I will re-work and re-land the refactoring later.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1f47989

xymus
xymus approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

beccadax
beccadax approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as long as it doesn't undo any of the renaming.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test Linux

@varungandhi-apple varungandhi-apple merged commit d32a371 into swiftlang:main Oct 26, 2020
@varungandhi-apple varungandhi-apple deleted the vg-revert-import-filtering-refactor branch October 26, 2020 20:42
@varungandhi-apple
Copy link
Contributor Author

This reverts PR #33986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xymus xymus xymus approved these changes

@beccadax beccadax beccadax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varungandhi-apple @swift-ci @xymus @beccadax