ASTScope: Remove "re-expansion" mechanism #34022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
changed the title
slavapestov
force-pushed
the
astscope-remove-re-expansion
branch
2 times, most recently
from
46d2245 to
4f9a684
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
changed the title
davidungar
suggested changes
Sep 22, 2020
|
@davidungar I'm planning on switching the call to getMembers() to use getParsedMembers() instead. This evaluates a request which produces a once-allocated ArrayRef which is guaranteed to never change. |
slavapestov
force-pushed
the
astscope-remove-re-expansion
branch
from
4f9a684 to
af627c2
Compare
slavapestov
force-pushed
the
astscope-remove-re-expansion
branch
from
af627c2 to
4bbdb95
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subset of the AST that participates in unqualified lookup should be effectively immutable. Delayed parsing can fill in members of nominal types and extensions, as well as function bodies, but since we lazily expand scopes, and the relevant getter methods on IterableDeclContext and AbstractFunctionBody trigger parsing, ASTScope should always see a consistent view of the world.