ASTScope cleanup in preparation for re-doing local pattern bindings #34039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
DifferentiableAttr, SpecializeAttr and CustomAttr create scopes because lookups can be performed from inside them. Previously we would sort DifferentiableAttr and SpecializeAttr by source order, but we consider that a declaration may also have more than one _kind_ of attribute requiring special handling. The case where this comes up is properties that have both a DifferentiableAttr and CustomAttr. This fixes test failures in AutoDiff tests with subsequent commits in this PR.
slavapestov
force-pushed
the
astscope-clean-up-pattern-bindings
branch
from
f24b736 to
7c43e10
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #34022: