Skip to content

Differentiate Cross-Module Incremental Dependencies #34075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2020

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 25, 2020

This still does not turn anything on. That'll wait until tomorrow.

  • Model the idea of a cross-module incremental dependency in the dependency graph.
  • Plumb that through to the serialized format.
  • Teach the DependencyTracker what an incremental external dependency is - but don't register any yet
  • Add the Driver-level fallback paths to treat incremental external dependencies like plain external dependencies.

…cker

Also perform the plumbing necessary to convince the rest of the compiler that they're just ordinary external dependencies. In particular, we will still emit these depenencies into .d files, and code completion will still index them.
This completes the missing piece from swiftlang#34073 and means the frontend may now serialize moduledecl-based dependencies.
Treat any incremental external depends like normal external depends. This will eventually become the fallback behavior for cross-module incremental builds.
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 25, 2020

@swift-ci test

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 25, 2020

@CodaFi CodaFi merged commit 1b6baf6 into swiftlang:main Sep 25, 2020
@CodaFi CodaFi deleted the crosstabs branch September 25, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant