Skip to content

Revert "Implement backward-compatible closure capture behavior with parser lookup disabled" #34163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Oct 2, 2020

Reverts #34135

This seems to have caused a few test regressions:
Failed Tests (2):
Swift(windows-x86_64) :: decl/var/property_wrappers.swift
Swift(windows-x86_64) :: SILGen/property_wrapper_local.swift

(Which also appear on Linux)

@compnerd
Copy link
Member Author

compnerd commented Oct 2, 2020

@swift-ci please clean test

@slavapestov
Copy link
Contributor

Here is the real fix: #34164

Can we just merge that one instead?

@compnerd
Copy link
Member Author

compnerd commented Oct 2, 2020

Yes please!

@compnerd compnerd closed this Oct 2, 2020
@swift-ci
Copy link
Contributor

swift-ci commented Oct 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - dc63bdf

@shahmishal shahmishal deleted the revert-34135-simulate-parser-lookup branch May 13, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants