AST: Find local property wrappers in ASTScope::lookupLocalDecls() #34164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
fix-local-property-wrappers
branch
from
7f43243 to
6ce876e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci please test windows platform |
Two fixes here: - The ASTScopeDeclConsumerForLocalLookup needs to visit auxiliary variables - preCheckExpression() should call ASTScope::lookupLocalDecls() even when parser lookup is enabled, since otherwise we won't be able to find auxiliary decls in the current DeclContext.
slavapestov
force-pushed
the
fix-local-property-wrappers
branch
from
6ce876e to
554e0f9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the build with #34135, because @hborla merged a PR and I didn't re-run the tests after that. The problem is there's now another AbstractASTScopeDeclConsumer subclass that needs to handle local property wrappers.
There's a bit of code duplication now; I'm going to clean it up later once CI is unblocked.