[build] Add FILES_MATCHING to CMakeLists.txt #34190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bare "PATTERN" argument by default does nothing, you need either "EXCLUDE" or "FILES_MATCHING" to make it do something. This likely wasn't previously a problem because clang is only installing headers, but it should be fixed for robustness.
|
CC @drexin @bulbazord for touching these |
edymtt
approved these changes
Oct 5, 2020
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci Please Build Toolchain Linux Platform |
|
@edymtt You can start toolchain by |
|
@swift-ci please smoke test Linux |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
Partially reverting this in #34241 to make the Compatibility Suite work again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bare
PATTERNargument by default does nothing, you need eitherEXCLUDEorFILES_MATCHINGto make it do something. This likely wasn't previously a problem because clang is only installing headers, but it should be fixed for robustness.